Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust binding for scanner.c #6

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Fix rust binding for scanner.c #6

merged 6 commits into from
Sep 6, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 5, 2023 •
edited
Loading

Fixes #7

Verified I don't get this error now locally.

Other changes:

  • We're now exporting all of the query files
  • Updated the grammar to support the new library syntax
  • Updated the grammar to support the new mod syntax (previously it was dep)
  • Added support for type aliases

The diff is huge because of the generated files under src/

@sdankel sdankel requested a review from a team September 6, 2023 00:22
JoshuaBatty
JoshuaBatty approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@JoshuaBatty JoshuaBatty requested a review from a team September 6, 2023 00:31
@sdankel sdankel merged commit 03d97aa into master Sep 6, 2023
4 checks passed
@sdankel sdankel deleted the sophie/scannerBinding branch September 6, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@sdankel sdankel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined symbols for architecture x86_64 when importing
2 participants
@sdankel @JoshuaBatty